Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline trigger should not consider end_date #159

Closed
raphaelrpl opened this issue Dec 14, 2021 · 1 comment
Closed

Timeline trigger should not consider end_date #159

raphaelrpl opened this issue Dec 14, 2021 · 1 comment
Assignees
@raphaelrpl
Labels
bug Something isn't working
Milestone
Version 1.0.0-alpha1

Comments

@raphaelrpl
Copy link
Contributor

The trigger bdc_catalog.triggers.timeline.sql is considering both start_date and end_date. For data cubes which has composition period, it turns out in wrong time line:

2020-01-01_2020-01-16    =>   2020-01-01, 2020-01-16
2020-01-17_2020-02-01    =>   2020-01-17, 2020-02-01

It should consider only start date

2020-01-01_2020-01-16    =>   2020-01-01
2020-01-17_2020-02-01    =>   2020-01-17
@raphaelrpl raphaelrpl added the bug Something isn't working label Dec 14, 2021
@raphaelrpl raphaelrpl added this to the Version 1.0.0 milestone Dec 14, 2021
@raphaelrpl raphaelrpl self-assigned this Dec 14, 2021
@raphaelrpl raphaelrpl pinned this issue May 3, 2022
@raphaelrpl raphaelrpl unpinned this issue May 3, 2022
@raphaelrpl
Copy link
Contributor Author

Resolved in #157 de1c296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelrpl raphaelrpl

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.0.0-alpha1
Development

No branches or pull requests
1 participant
@raphaelrpl