Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Shopguiplus with SuperiorSkyblock #34

Open
Distolfix opened this issue Mar 26, 2023 · 4 comments
Open

Bug Shopguiplus with SuperiorSkyblock #34

Distolfix opened this issue Mar 26, 2023 · 4 comments
Labels
invalid This doesn't seem right

Comments

@Distolfix
Copy link

Distolfix commented Mar 26, 2023

Dear developer,

I am writing to inform you that your plugin has a problem that prevents it from working with SuperiorSkyblock2. At the end of this message, I will send you a GitHub link that I kindly ask you to respond to, as I am also in contact with the developer of the skylock to solve this problem. The bug is in your plugin i think.

The issue is that the skyblock plugin requests the prices of your shop for the "is top" function, but your plugin loads the shops after the server leaves a "Done" message. If a player enters while the server is still loading, an error occurs because your plugin has not yet loaded the shops and it appears that they do not exist. Please read the GitHub link I am sending you and kindly respond to it.

BG-Software-LLC/SuperiorSkyblock2#1645 (comment)

Thank you.

@brcdev
Copy link
Member

brcdev commented Mar 26, 2023

Hello!
I understand your and the other developer's point, but due to the way ShopGUI+ handles its own dependencies (and the fact is must ensure they are loaded before it enables itself, where i.e. HeadDatabase also loads its heads after the server is loaded and players already can join) this behaviour can't be changed. As a result, there's the ShopGUIPlusPostEnableEvent even that should be used instead.
As you have already noticed in the other ticket, there is an example showing the correct & safe way to hook included in readme of this repo we're currently in. I've also added another example of how one can ensure shops are loaded.
I will leave this ticket open for now, but I don't really see any way we could improve it on our end, especially until other plugins hook into ShopGUI+ the recommended way.

@brcdev brcdev added the invalid This doesn't seem right label Mar 26, 2023
@Distolfix
Copy link
Author

you have been very kind, thank you for your availability and for your answer. I hope that with your professionalism we can fix the bug of SuperiorSkyvblock

@Distolfix
Copy link
Author

if you can leave the ticket open so Omer (superior Skyblock developer) can fix the bug

@Distolfix
Copy link
Author

please dear developer can you reply on the other ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants