Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto close duplicate only in certain conditions #34

Open
achillez16 opened this issue Jul 15, 2023 · 1 comment
Open

Auto close duplicate only in certain conditions #34

achillez16 opened this issue Jul 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@achillez16
Copy link

achillez16 commented Jul 15, 2023

Is your feature request related to a problem? Please describe.
Auto close is most useful when you open a link that you don't know has a tab already open among the 100 others. However there are times when you are just trying to diff between 2 same links etc and the user can right click a tab and select duplicate.

Describe the solution you'd like
The user intent when they click duplicate is to have a duplicate tab and the extension should honor that intent. So it would be good to have an option in the settings for the user to disable auto close when clicking on duplicate tab.

Describe alternatives you've considered
NA

Additional context
NA

@brcontainer
Copy link
Owner

brcontainer commented Jul 16, 2023

The new version is almost ready (I'm being very careful with the tests), your suggestion is very welcome, the initial problem with it is that the "duplicate guide" feature has no indication in the official extensions API, see:

Documentation:

However I said at the beginning, I promise that I will think of a resource based on "tabs.Tab.tabId" to add the tabs in an exception, the complicated thing about this part is that there is no way to differentiate a tab coming from the "Duplicate Guide" menu ", but I will try to come up with an alternative form that serves this well.

For now what you can use, which already exists, are the resources:

  • ignore domain
  • ignore url

Before duplicating the tab, click on the extension icon and then click on the eye icon:

image

@brcontainer brcontainer added the enhancement New feature or request label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants