switch to old tab if active is closed #37

forivall · 2023-10-18T02:38:03Z

Fixes #36 (scenario 2)

I also add a bunch of jsdoc and such so typescript can understand the code. (also, changed substr to slice, since substr is deprecated). Could use substring instead, but i prefer slice). If undesired, we can just merge the commit with the change: main...forivall:prevent-duplicate-tabs:feature/switch-to-existing

gabriel-r

@forivall I'd be happy to test and review this but my skills are limited.
Can you push a branch that I can easily check out?
PS: Or, teach me how to get the code on my machine.

forivall added 3 commits October 17, 2023 19:13

fix: remove use of deprecated substr

bcaf45a

docs: add jsdoc typings

9ef2e20

feat: switch to old tab if active is closed

bb5ee5d

gabriel-r reviewed Apr 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch to old tab if active is closed #37

switch to old tab if active is closed #37

forivall commented Oct 18, 2023 •

edited

gabriel-r left a comment •

edited

switch to old tab if active is closed #37

Are you sure you want to change the base?

switch to old tab if active is closed #37

Conversation

forivall commented Oct 18, 2023 • edited

gabriel-r left a comment • edited

Choose a reason for hiding this comment

forivall commented Oct 18, 2023 •

edited

gabriel-r left a comment •

edited