Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPhone X optimization #17

Closed
blommegard opened this issue Nov 6, 2017 · 4 comments
Closed

iPhone X optimization #17

blommegard opened this issue Nov 6, 2017 · 4 comments

Comments

@blommegard
Copy link

Breadwallet already supports iPhone X, but there are a bunch of layout issues, too small images and the tight coupling of Touch ID == biometrics auth.
@losh11
Copy link
Contributor

losh11 commented Nov 7, 2017

I'm going to have a stab at this tomorrow. Although it looks like the breadapp guys have been inactive for a month, so no idea if they will merge my PR.

@samuraisam
Copy link
Member

We're still around! We only push to this repo on releases now, but would be happy to receive any pull requests!

@blommegard
Copy link
Author

Is there a specific reason for this @samuraisam, feels hard to contribute on a codebase that is evolving in private?

@losh11
Copy link
Contributor

losh11 commented Nov 8, 2017

@blommegard created PR #18 to solve this issue.

@tt tt mentioned this issue Dec 21, 2017
Closed
@ewerx ewerx closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blommegard @samuraisam @ewerx @losh11