Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key up events rollover #134

Closed
jackokring opened this issue Nov 2, 2023 · 1 comment
Closed

Key up events rollover #134

jackokring opened this issue Nov 2, 2023 · 1 comment

Comments

@jackokring
Copy link

In agon_ps2.h

	#endif
	
	if (kb->getNextVirtualKey(&item, 0)) {
		//if (item.down) {//keycode up events are still true mapping. how would _keycode change?
			switch (item.vk) {
				case fabgl::VK_LEFT:
					_keycode = 0x08;
@stevesims
Copy link
Contributor

in the real code that if statement is not commented out, and so the switch statement that follows which will result in _keycode being updated will only run for key down events.

therefore for key up events, the value returned via the keycode argument will be whatever _keycode was last set to.

the keyboard data packet sent thru to MOS via the VDP protocol will include that returned keycode, as well as the item.vk and item.down

@breakintoprogram breakintoprogram closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants