Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet mode coded to not work #56

Closed
vqmalic opened this issue Jun 24, 2018 · 3 comments
Closed

Quiet mode coded to not work #56

vqmalic opened this issue Jun 24, 2018 · 3 comments
Assignees
Labels

Comments

@vqmalic
Copy link

vqmalic commented Jun 24, 2018

Thank you for this useful tool. It's really useful in the work I'm doing right now.

In manager.py, the SceneManager object takes quiet_mode as a Boolean keyword argument, but line 64 always initializes it to False.

@Breakthrough
Copy link
Owner

Good catch, thank you @vqmalic!

@Breakthrough
Copy link
Owner

Breakthrough commented Jul 3, 2018

The SceneManager class is going under a major overhaul just to give you a heads up, have started a complete rewrite of the project. The new API is being developed following test driven development principles and will have plenty of unit tests to show example usage and error handling.

If you'd like a preview of some of the work or to give any feedback/suggestions you have for things you would like to see in the new API (or things in the old API that you think I might overlook during the transition) please let me know here: #57

Also just curious, what specific version(s) of Python do you use, and if you are still using Python 2, do you have any plans to transition to Python 3 in the future?

Thank you @vqmalic !

@Breakthrough
Copy link
Owner

In v0.5, in addition to the --quiet/-q flag, there will also be an --info-level/-il option which has values none, debug, info (default), and error which is the minimum level of messages to display. Setting -il none in v0.5 will suppress all non-essential output, which is what the same thing -q flag used to do in v0.4 and previous.

In v0.5, the -q flag overrides the current info-level with none, achieving the same result (suppression of non-essential output).

I have completed the necessary changes for v0.5 and committed them to that version's development branch, and marked this issue as complete. I will leave it open, however, until the changes have been merged with master, and the v0.5 release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants