Location background theme does not affect cards colour

[elydpg]

Steps to reproduce

1. Choose a location. Make sure "day/night mode for locations" is enabled
2. Change its theme to be "always day" if it is currently night, and "always night" if it is currently day

Expected behavior

The cards change to match the theme

Actual behavior

The cards do not change. See the demo below:

Screen_Recording_20240610_014415_Breezy.Weather_1.mp4

Weather source used

N/A

Breezy Weather version

5.2.4 standard

Android version

12

Device

Samsung Galaxy s10e

Other details

This might be a case of poor documentation and not a bug. If the setting "day/night mode for locations" is enabled, then the location cards colour always matches the day/night time for the location, regardless of the background theme. If it is disabled, then the cards colour follows the system theme, again regardless of the background theme. If this is the correct intended behaviour, then the option to edit a location's theme should probably say explicitly "Background Theme".

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open OR closed issue.
• I checked that my issue is not covered in the Frequently Asked Questions document.
• I have updated the app to version 5.2.4 or later and I can reproduce the issue in this version.
• I wrote my request in English, and any screenshot I attached are also in English (language can be changed from Settings > Appearance), unless my issue only happens with a specific language. I can write in my native language under the English text, if necessary.
• I understand that this app is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY, so I may not get a positive reply to my request, if any at all.

[papjul]

It has never been implemented that way. I'm not sure what we should do.

• I'm not sure I want to add another condition of top of all the tricky logic about theming. It's already not easy to test every existing cases.
• The wording matches the one from the wallpaper settings screen

Will leave to Needs review and decide later

[elydpg]

The wording matches the one from the wallpaper settings screen

Do you mean this wallpaper settings screen?

If so, then I'm referring strictly to the word "theme" in this screen, which does not appear on that screen:

This should probably be changed to "Background Theme" or perhaps simply "Background" or "Wallpaper", to distinguish it from the colour of the cards