Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather condition names follow system language over app language on Android < 13 #1132

Closed
5 tasks done
elydpg opened this issue Jun 13, 2024 · 6 comments
Closed
5 tasks done
Labels
Bug Something isn't working Device-specific Issues that only affect some devices

Comments

@elydpg
Copy link

elydpg commented Jun 13, 2024

Steps to reproduce

  1. Make sure the app is set to English and NOT "Follow System"
  2. Set the system language to Spanish and restart the app
  3. Add a new location with source Open-Meteo (so as to avoid using cached data)

Expected behavior

Weather condition names appear in the app language (English)

Actual behavior

Weather condition names appear in the system language (Spanish):

Screenshot_20240613-190304_Breezy Weather
Screenshot_20240613-190318_Breezy Weather
Screenshot_20240613-190335_Breezy Weather

Weather source used

Open-Meteo, MET Norway, Meteo-France, DMI, probably others

Breezy Weather version

5.2.4 standard

Android version

12

Device

Samsung Galaxy s10e

Other details

This behaviour happens from pretty much all worldwide sources that I tried, as well as the IMS (Yes apparently the IMS can provide weather condition names in Spanish; who knew?) and NWS. Notable exceptions include:

Meteo-France: Current weather condition follows system language, Forecast weather conditions are always in French (Since Meteo-France doesn't localize forecast weather conditions - see #1130)

AccuWeather: All weather conditions are in English only (probably because AccuWeather doesn't localize anything)

ECCC: Strangely, always in English. Except if the current weather condition is Thunderstorms, that follows the system language for some reason (though forecasts are only in English):

Screenshot_20240613-195738_Breezy Weather

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open OR closed issue.
  • I checked that my issue is not covered in the Frequently Asked Questions document.
  • I have updated the app to version 5.2.4 or later and I can reproduce the issue in this version.
  • I wrote my request in English, and any screenshot I attached are also in English (language can be changed from Settings > Appearance), unless my issue only happens with a specific language. I can write in my native language under the English text, if necessary.
  • I understand that this app is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY, so I may not get a positive reply to my request, if any at all.
@elydpg elydpg added Bug Something isn't working Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc) labels Jun 13, 2024
@papjul
Copy link
Collaborator

papjul commented Jun 14, 2024

Your issue only happens because you changed system language recently. No one does that. I have my system language set to French and app language set to English and never encountered any issue.

Please try to clear cache data first. Custom language per app is natively and fully supported only starting from Android 13 and previous Android versions are known to keep cache even if system language was changed recently.

@elydpg
Copy link
Author

elydpg commented Jun 14, 2024

I don't think it has to with clearing my cache; I tried again but this time I cleared the app cache and restarted my phone after switching the language. Still happens:

Screenshot_20240614-120208_Breezy Weather.png

I'm pretty sure it isn't serving me cached data since this screenshot was just after an automatic refresh. The data from before the automatic refresh is in English as I would expect:

Screenshot_20240614-115302_Breezy Weather.png

@papjul
Copy link
Collaborator

papjul commented Jun 14, 2024

This issue is not reproducible in Android 14.

Custom language per app is natively and fully supported only starting from Android 13

I recommand you update to the latest version of Android and retry

@papjul papjul added Device-specific Issues that only affect some devices and removed Needs review Issue that need to be analyzed (reproduced for a bug, take a decision for an idea, etc) labels Jun 14, 2024
@papjul papjul changed the title Weather condition names follow system language over app language Weather condition names follow system language over app language on Android < 13 Jun 14, 2024
@elydpg
Copy link
Author

elydpg commented Jun 14, 2024

So my device doesn't support Android 13+ so I can't do that :( However I tested it in a Pixel 8 Pro emulator in Android 12, 13, and 14 and I can confirm that it's buggy just like on my device in Android 12 and working as intended on Android 13 and 14.

These quirks are still present though:

Meteo-France: Current weather condition follows system language, Forecast weather conditions are always in French (Since Meteo-France doesn't localize forecast weather conditions - see #1130)

AccuWeather: All weather conditions are in English only (probably because AccuWeather doesn't localize anything)

ECCC: Strangely, always in English. Except if the current weather condition is Thunderstorms, that follows the system language for some reason (though forecasts are only in English):

In particular, that ECCC localizes only current weather thunderstorms and nothing else is still a problem but that's a separate issue

@papjul
Copy link
Collaborator

papjul commented Jun 14, 2024

Features that will no longer be available

  • Backport features/fixes from latest Android versions to older Android versions

Re-implementing the per-app language feature from Android 13+ in Android < 13 falls in this category.

@elydpg
Copy link
Author

elydpg commented Jun 14, 2024

Yep was just confirming that it's an Android < 13 issue. Will close then

@elydpg elydpg closed this as completed Jun 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Device-specific Issues that only affect some devices
Projects
None yet
Development

No branches or pull requests

2 participants