Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body only parsed for POST requests, should we not also parse PUT+PATCH ? #1688

Open
PaulMcITS opened this issue Nov 9, 2023 · 2 comments
Open

Body only parsed for POST requests, should we not also parse PUT+PATCH ? #1688

PaulMcITS opened this issue Nov 9, 2023 · 2 comments
Labels
bug

Comments

@PaulMcITS
Copy link

In Bref\Event\Http\Psr7Bridge , parseBodyAndUploadedFiles, there is a check that the event method is 'POST' before parsing the body. Should we not also look to parse the body of PUT and PATCH requests?
@PaulMcITS PaulMcITS added the bug label Nov 9, 2023
@mnapoli
Copy link
Member

mnapoli commented Nov 9, 2023

That sounds reasonable to me 👍

Feel free to send a PR with tests if you have time.

@PaulMcITS
Copy link
Author

I'll try to fit it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnapoli @PaulMcITS