Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite #51

Open
surister opened this issue Dec 17, 2019 · 7 comments
Open

Test suite #51

surister opened this issue Dec 17, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request wip working in progress

Comments

@surister
Copy link
Contributor

surister commented Dec 17, 2019

Issue merges from #50 .

While trying to do a simple bash script of this I came across many problems since there are many ways of spacing/formatting within the same layout, the bash script was getting a bit bloated and decided to make it in python.

One of the issues of counting questions and answers are typos. So I wrote a test suit to check for these, it's working great.

imagen

Notice the missing '/' from the closing summary tag.

So my new proposal is:

  • Add Suggestion: Add number of answered questions. #50 (Already aproved)
  • Create test suite where we will be checking:
    1. typos in tags
    2. layout correctly followed
    3. Correct number of answered questions count
    4. Correct number of question count (The bash script that counts questions may not be counting correctly due to typos in tags)

Having this test suit will allow us to check our commits before pushing thus improving the general quality.

Also we could land a CI pipe for new pull requests, offering faster feedback to contributors.

@bregman-arie
Copy link
Owner

That is awesome. I wanted for some time to add a simple .travis.yml to start doing simple checks since I accidentally merged in the past PRs which weren't following the format correctly.
As always, you summarized the problem and solution in a very detailed way. Let's do it :)

@surister surister changed the title [NEW FEATURE] [PROPOSAL] [NEW FEATURE] [WIP] - TEST SUITE Dec 17, 2019
@surister surister self-assigned this Dec 17, 2019
@surister surister added the enhancement New feature or request label Dec 17, 2019
@surister
Copy link
Contributor Author

Great, I will be working this issue in a new branch and use this issue to keep you informed.

@surister
Copy link
Contributor Author

#53 Found many miss written tags, works great so far.

@bregman-arie
Copy link
Owner

Great, I've added a .travis.yml for running it regularly as part of the review process.
I need to fix some of the Python PEP8 issues before enabling it.

@surister
Copy link
Contributor Author

If you don't mind i will add '--max-line-length=100' to flake 8 because 79 is almost never enough and will cause us more problems than anything.
For reference

PEP 8, the Python style guide, recommends a 79 character maximum line length but concedes that a line length up to 100 characters is acceptable for teams that agree to use a specific longer line length

@bregman-arie
Copy link
Owner

Fine by me

@surister surister added the wip working in progress label Jan 9, 2020
@surister surister changed the title [NEW FEATURE] [WIP] - TEST SUITE Test suite Jan 9, 2020
@ParadigmSupportProgramming

Catfish Belly Frogger Farm working 22NB BaseCloud💸 Request Fundraiser of Cold Hades Ductwork System filtration guard Un-attached otherwise. Unknown point of view pertaining to payroll as to the unknown contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip working in progress
Projects
None yet
Development

No branches or pull requests

3 participants