default value type 'string' correctly handled?

[dehubbed]

As per spec: "If no type is indicated, the type is string." Is this being correctly handled? Running necessary-evil as client against the Java XML-RPC reference implementation as server I get responses in the form of

<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>foo</name><value></value></member><member><name>bar</name><value>xyz</value></member></struct></value></param></params></methodResponse>

which cause NullPointerExceptions in clojure.zip$node.invoke. Note that the response don't specify the type on strings and even contains empty string both of which are legit AFAIK.

[brehaut]

It should be handling untyped parameters as strings correctly. However, there may be a bug around empty parameters, and i can reproduce your issue. I'll look into producing a fix for this over the next few days.

(Also, do you have a citation for the java xml-rpc imp being the reference implementation? I have found the spec to be silent on the issue, and id like to know)

[dehubbed]

Thanks for the coming fix -- normally I'd do it myself but I'm relatively new to Clojure. As for the reference implementation, not sure why I was thinking that. May just have been me with my Java goggles on.

[brehaut]

I have put a fix in place that resolves this issue.

I'll back port this to a 1.2.x branch and release that along with the next 2.0.0-SNAPSHOT.