Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetches older post as new when a post is removed. #19

Closed
fuzzfactory0 opened this issue Aug 2, 2019 · 3 comments
Closed

Fetches older post as new when a post is removed. #19

fuzzfactory0 opened this issue Aug 2, 2019 · 3 comments
Assignees
Labels

Comments

@fuzzfactory0
Copy link

Describe the bug
Every time a post is deleted from the subreddit you're watching, the Xth post on the subreddit will get reposted in your feed (Assuming X is the number of results configured in your code.)

To Reproduce
Steps to reproduce the behavior:

  1. Submit more posts than the "results" config to a subreddit you're watching
  2. Remove the latest post
  3. See error

Expected behavior
Nothing. When a post is removed, it should do nothing.

Additional context
This happens because of how new posts are detected by comparing batches and removing duplicates. When a post is removed, the new batch will have an older post than every post in the previous batch, and that one is treated as new by the code.
Easy fix: compare timestamps between posts.

@brenapp
Copy link
Owner

brenapp commented Aug 13, 2019

Generally, there are a lot of unexpected behaviors that can come from setting results too low. Is snoostorm reissuing new events for posts it has handled in the past? Cause that is aberrant behavior. For now, until I can properly triage, setting results higher (usually 25 posts is good for all of reddit)

@brenapp
Copy link
Owner

brenapp commented Aug 23, 2019

So far, I've been unable to replicate this issue. Can you give me a minimal verified example?

@brenapp
Copy link
Owner

brenapp commented Jun 4, 2020

Cannot replicate, see if this issue is still a problem with snoostorm@1.4.0

@brenapp brenapp closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants