Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definition for GenerateOptions.symbols is missing 'string' in Yarn package #59

Closed
theRealPadster opened this issue Jun 28, 2021 · 2 comments
Closed

Typescript definition for GenerateOptions.symbols is missing 'string' in Yarn package #59

theRealPadster opened this issue Jun 28, 2021 · 2 comments

Comments

@theRealPadster
Copy link

theRealPadster commented Jun 28, 2021 •
edited
Loading

I'm not sure how this happened, but I installed the latest version of this package off Yarn and it says it's v1.6.0, but the typescript definition has the symbols option as just a boolean. It looks like this was fixed in Git a while ago.

If I click "browse files" in the Yarn page sidebar, I can see the file here, without the 'string' type.
@gabzidevs
Copy link

gabzidevs commented Jul 21, 2021 •
edited
Loading

#55 is still pending for release I think.

Update: For the meantime, you can just cast the correct typing onto the function itself. Worked well for me.

@brendanashworth
Copy link
Owner

Thanks for the bump guys, just published 1.6.1 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theRealPadster @brendanashworth @gabzidevs