Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Better to add about generate-password-browser in the readme #73

Closed
yadunandanbhat opened this issue Apr 13, 2022 · 3 comments
Closed

[DOC] Better to add about generate-password-browser in the readme #73

yadunandanbhat opened this issue Apr 13, 2022 · 3 comments

Comments

@yadunandanbhat
Copy link
Contributor

As some people might want to run this in a browser environment, I think it would be better if we mentioned that this doesn't have browser support and instead use the forked project 'generate-password-browser'? would be helpful for beginners!
@brendanashworth
Copy link
Owner

That would be a good addition to the readme, do you want to submit a pull request?

@yadunandanbhat
Copy link
Contributor Author

Yes, would love to!

@yadunandanbhat
Copy link
Contributor Author

Opened a pr #74. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendanashworth @yadunandanbhat