funcgraph, funcslower, functrace: Make -p switch respect all the process' threads #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -p switch used to set the `set_ftrace_pid` file, which is really a thread id from the user's perspective. As a result, only the main thread would be traced. Fix by enumerating the thread ids from /proc/ $pid/task and putting them all in `set_ftrace_pid` when asked. Signed-off-by: Sasha Goldshtein <goldshtn@gmail.com>
Signed-off-by: Sasha Goldshtein <goldshtn@gmail.com>
Signed-off-by: Sasha Goldshtein <goldshtn@gmail.com>
|
There are quite a few additional tools, which use perf |
|
Addressed the other tools in #56. |
|
@brendangregg Could you please take a look? |
|
Thanks! I'll accept it as it's supposed to work. You didn't break anything. But there are issues with older kernels to be aware about. From a quick test:
|
|
That's really weird. I can find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53 for the tools that use
set_ftrace_pidas the filtering technique.Now, traverse /proc/$pid/task to find the "kernel" pids (thread ids) and use
them instead. Also, add -L switch if anyone really wants thread-based filters.