Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot omit tag values for DeleteTags #270

Closed
oswynb opened this issue Jan 20, 2016 · 2 comments
Closed

cannot omit tag values for DeleteTags #270

oswynb opened this issue Jan 20, 2016 · 2 comments

Comments

@oswynb
Copy link

oswynb commented Jan 20, 2016

In Network.AWS.EC2.DeleteTags, there is no way to omit the value of a tag, since the exposed lens requires a [Tag] : dtsTags :: Lens' DeleteTags [Tag] but Tag has compulsory keys and values: tag :: Text -> Text -> Tag, tagValue :: Lens' Tag Text
@brendanhay
Copy link
Owner

Hmm, seems like a problem with the service definition. What happens if the value is empty? Does EC2 still delete the tag or does it fail since the tag exists with a value?

@oswynb
Copy link
Author

oswynb commented Jan 20, 2016

The expected behaviour is the tag with matching key will be deleted regardless of its value

brendanhay added a commit that referenced this issue Mar 20, 2016
@brendanhay
Supplant DeleteTag's use of Tag with a custom DeleteTag type
e24b594 
DeleteTag features a value component which will not be serialised
into a request if absent.

Fixes #270
brendanhay added a commit that referenced this issue Mar 20, 2016
@brendanhay
Supplant DeleteTag's use of Tag with a custom DeleteTag type
d7aa427 
DeleteTag features a value component which will not be serialised
into a request if absent.

Fixes #270
brendanhay added a commit that referenced this issue Mar 20, 2016
@brendanhay
Supplant DeleteTag's use of Tag with a custom DeleteTag type
fe1071f 
DeleteTag features a value component which will not be serialised
into a request if absent.

Fixes #270
@brendanhay brendanhay mentioned this issue Mar 20, 2016
Merged
brendanhay added a commit that referenced this issue Mar 20, 2016
@brendanhay
Supplant DeleteTag's use of Tag with a custom DeleteTag type
16b9299 
DeleteTag features a value component which will not be serialised
into a request if absent.

Fixes #270
brendanhay added a commit that referenced this issue Mar 20, 2016
@brendanhay
Supplant DeleteTag's use of Tag with a custom DeleteTag type
55ed92d 
DeleteTag features a value component which will not be serialised
into a request if absent.

Fixes #270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendanhay @oswynb