-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on large html #39
Comments
Ahhhh of course! So in retrospect this siteType option needs to be implemented differently, it should just write to a file rather than unsafely pass the potentially long string as an argument to the process. Of course, writing to a file is something the caller could do anyways, so I don't think there's actually a need for this option. As for #40, you should be able to just use a file:// path to load a local file, which is what's done in the tests. |
For writing to temporary files there is https://npmjs.org/package/tmp that could make it easy get a temp path that gets removed after the session. I replied to your comment on #40 in it's own thread (as that is my original issue for now). |
Thanks for the pointer, the tmp module should be helpful in implementing a fix for this issue. |
I see it, very nice. |
I get this scary error then using long html strings:
The text was updated successfully, but these errors were encountered: