Potential fix for an issue due to reliance on relative date #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the SparkLine will only show SparkLineDay objects whose date does not differ from the current date by more than X days. Where X is the number of SparkLineDay objects passed into the SparkLine object (maxItemAmount). That is because inside the resolveCoordinates method a collection of dates is created that is relative to the current date. Then those dates are used to find entries in the collection of SparkLineDay objects whose dates are not guaranteed to be relative to the current date. This commit changed the way the SparkLineDay object of a day is retrieved by relying on the sort order of the $days collection.
der-Lehmann
changed the title
|
v2 gets rid of the concept of days, so we don't need to fix this anymore :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 an issue where the SparkLine will only show SparkLineDay objects whose date does not differ from the current date by more than X days. Where X is the number of SparkLineDay objects passed into the SparkLine object (maxItemAmount).
That is because inside the resolveCoordinates method a collection of dates is created that is relative to the current date. Then those dates are used to find entries in the collection of SparkLineDay objects whose dates are not guaranteed to be relative to the current date.
This commit changed the way the SparkLineDay object of a day is retrieved by relying on the sort order of the $days collection.