Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❓ Not used Blade files? #322

Closed
SerhiiCho opened this issue Sep 18, 2023 · 2 comments · Fixed by #323
Closed

❓ Not used Blade files? #322

SerhiiCho opened this issue Sep 18, 2023 · 2 comments · Fixed by #323
Assignees
@SerhiiCho
Labels
dead code Issues and PRs that remove code that is not used feedback wanted Issues and PRs which require help of others

Comments

@SerhiiCho
Copy link
Collaborator

SerhiiCho commented Sep 18, 2023 •
edited
Loading

I was cleaning up blade files and just noticed that we have register.blade.php and login.blade.php in resources/views directory. I means that login and register blade files in resources/views/auth directory are not used? I just missed that moment somewhere.

In other words, we have 2 login files and 2 register blade files. Should we delete those in auth directory? There is also a two-factor-challenge.blade.php, is it used anywhere?

When I delete login and register files in auth directory, nothing changes. The site works as it worked with them.
@SerhiiCho SerhiiCho added the feedback wanted Issues and PRs which require help of others label Sep 18, 2023
@SerhiiCho SerhiiCho changed the title Not used Blade files? ❓ Not used Blade files? Sep 18, 2023
@SerhiiCho
Copy link
Collaborator Author

There is also a register-pending.blade.php file that has a route but not used anywhere

@SerhiiCho SerhiiCho mentioned this issue Sep 21, 2023
Merged
@SerhiiCho SerhiiCho self-assigned this Sep 21, 2023
@SerhiiCho SerhiiCho added the dead code Issues and PRs that remove code that is not used label Sep 21, 2023
@SerhiiCho
Copy link
Collaborator Author

There are in total 10 files that need to be removed since they are not used anywhere. I deleted them here in #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SerhiiCho SerhiiCho

Labels
dead code Issues and PRs that remove code that is not used feedback wanted Issues and PRs which require help of others
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed blade files in auth dir SerhiiCho/rfc-vote
1 participant
@SerhiiCho