Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdoutp(), stderrp(), and stdinp() for Windows #58

Merged
merged 1 commit into from
May 20, 2024

Conversation

daizutabi
Copy link
Contributor

@daizutabi daizutabi commented May 20, 2024

On Windows, stdoutp(), stderrp(), and stdinp() don't work:

julia> @assert Sys.iswindows()
julia> using StaticTools
julia> stdoutp()  # stderrp(), stdinp()
JIT session error: Symbols not found: [ stdout ]
...

After this PR:

julia> stdoutp()
Ptr{StaticTools.FILE} @0x00007ffa2bb8f4f8
julia> stderrp()
Ptr{StaticTools.FILE} @0x00007ffa2bb8f550
julia> stdinp()
Ptr{StaticTools.FILE} @0x00007ffa2bb8f4a0

@brenhinkeller brenhinkeller merged commit 9fe2744 into brenhinkeller:main May 20, 2024
5 of 8 checks passed
@brenhinkeller brenhinkeller mentioned this pull request May 20, 2024
@mkitti
Copy link
Contributor

mkitti commented May 20, 2024

I assume this is meant to only address 64-bit Windows based on the assertions.

@brenhinkeller
Copy link
Owner

brenhinkeller commented May 20, 2024 via email

@daizutabi daizutabi deleted the fix-stdio-win branch May 20, 2024 20:20
daizutabi referenced this pull request in daizutabi/StaticCompiler.jl May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants