New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another Way For Graceful Shutdown #15

Closed

trylovetom opened this issue Oct 31, 2017 · 1 comment

trylovetom commented Oct 31, 2017

I got a solution that work with PM2, it will fix some problem about:

Correct PID 1 signals Handling & Forwarding
Graceful application Start and Shutdown
Seamless application clustering to increase performance and reliability

Docker-PM2-NodeJS

Owner

BretFisher commented Nov 5, 2017

Thanks @trylovetom PM2 is cool, but IMO this is an anti-pattern and it's use is replaced by docker.

It creates another wrapper around the node executable thus reducing docker's visibility and control of node directly.
You want docker to control the number of instances via replicas of the container. Having PM2 do it creates a nesting problem of unneeded complexity.

BretFisher closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment