Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle HTTP 202 ACCEPTED as successful #174

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

astrojuanlu
Copy link
Contributor

Closes #171.

@astrojuanlu astrojuanlu force-pushed the properly-handle-202-accepted branch 2 times, most recently from a50ed65 to 9203f62 Compare January 10, 2022 21:00
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, and thanks for updating the contributing guide accordingly. It just needs small rst formatting.

Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@brettcannon brettcannon self-requested a review January 11, 2022 22:26
@brettcannon brettcannon merged commit 734ff53 into gidgethub:main Jan 14, 2022
@brettcannon
Copy link
Collaborator

Thanks!

@astrojuanlu astrojuanlu deleted the properly-handle-202-accepted branch January 15, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

202 ACCEPTED considered as error
3 participants