Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we switch from javax.* to jakarta.*? #1807

Closed
larsnaesbye opened this issue Jul 14, 2021 · 2 comments
Closed

Should we switch from javax.* to jakarta.*? #1807

larsnaesbye opened this issue Jul 14, 2021 · 2 comments

Comments

@larsnaesbye
Copy link

As the namespace has changed in newer versions due to the transfer of JavaEE to Eclipse Foundation, we could update by replacing imports and references. I could make a PR if you so wish.

@froque
Copy link

froque commented Jul 29, 2021

I don't think this applies to HikariCP.

The only javax.* usages I could find were javax.sql, javax.management and javax.naming, and these are Unaffected (Non-EE) Packages

There is a usage of javax.inject but in test scope only:

$ git grep -e javax --and --not -e javax.sql --and --not -e javax.management --and --not -e javax.naming 
pom.xml:189:         <groupId>javax.inject</groupId>
pom.xml:190:         <artifactId>javax.inject</artifactId>
src/test/java/com/zaxxer/hikari/osgi/OSGiBundleTest.java:30:import javax.inject.Inject;

@larsnaesbye
Copy link
Author

Cool. I hadn't noticed that these were unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants