Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Good Color Scheme #14

Closed
MichaelWashburnJr opened this issue Oct 5, 2016 · 10 comments
Closed

Add Good Color Scheme #14

MichaelWashburnJr opened this issue Oct 5, 2016 · 10 comments

Comments

@MichaelWashburnJr
Copy link
Member

Still using a blank white scheme, if someone wants to add some color to the scss, that'd be great.

@ankit01ojha
Copy link

Can you please tell me in which file of scss folder does the color option is?

@MichaelWashburnJr
Copy link
Member Author

@ankit01ojha openbrews/openbrews.app.scss has default color options at the top that you can play around with. They are commented out, but if you uncomment them and start setting their values they should work.

@briantwatson
Copy link
Contributor

@mdw7326, I'll take a stab at it. I'll just use the colors eric used and apply them to the file you've described

@MichaelWashburnJr
Copy link
Member Author

That works @briantwatson, thank you (referring to #50). I'm going to keep this issue open however in case someone wants to get creative. For example, if someone wants to add more creative colors for backgrounds, buttons, fonts, etc. It would be welcome still. Currently, the app looks a little generic still.

@briantwatson
Copy link
Contributor

@mdw7326, sounds good. New to Angular etc. so I need to roll my sleeves up and see what I can do. Was a homebrewer for some years, so this piqued my interest.

@icyflame
Copy link
Collaborator

@mdw7326 @briantwatson I am not too sure what changes were made in the color scheme. The app looks exactly the same to me, is there some step that I am missing? I am doing the same gulp && ionic serve or gulp && ionic upload. I don't see any change the overall color scheme!

@MichaelWashburnJr
Copy link
Member Author

@icyflame They were very subtle changes, which is why I kept the issue open. One example is, I think the green buttons are slightly darker now.

@codeavenger07
Copy link

@mdw7326, mind if I take a stab at this?

@MichaelWashburnJr
Copy link
Member Author

@codeavenger07 Go ahead!

@MichaelWashburnJr
Copy link
Member Author

I think this is good enough for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants