Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configuration Management #28

Closed
MichaelWashburnJr opened this issue Oct 6, 2016 · 1 comment
Closed

Add Configuration Management #28

MichaelWashburnJr opened this issue Oct 6, 2016 · 1 comment

Comments

@MichaelWashburnJr
Copy link
Member

We should make it so the main module (openbrews.js) reads in values from a config file (openbrews.config.json). We should not add the config file to the repository, but we should add an example config to the repository (something named like openbrews.config.ex.json).

This is needed at minimum to store the brewerydb API key for the app. I will keep a concrete config in a gist and share it upon request with developers.

@lricoy
Copy link

lricoy commented Oct 6, 2016

I may be able to take a look at that issue and others one later today. Thanks for putting the Hacktoberfest label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants