This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
#22 - countries model #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # database/seeders/DatabaseSeeder.php
|
Guys, I would be grateful if you could take a look here. I don't know if we want to continue with these database countries or maybe should I move them into some helper class or whatever? |
# Conflicts: # composer.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we were discussing relation brewery-countries, but I think in any option we will need table with actual countries/departments/territories/whatever. I took data from here.
I added:
I was thinking about using my package for conditinal seeders for
RealWorldCountriesSeeder, but I would rather ask you for your opinion.It should close #22.