Skip to content
This repository has been archived by the owner on Dec 30, 2019. It is now read-only.

1.6.0 broke backward compatibility by returning undefined on connect() #38

Closed
diegoperini opened this issue Dec 7, 2016 · 5 comments
Closed

Comments

@diegoperini
Copy link

No description provided.

@charmander
Copy link
Collaborator

charmander commented Jan 27, 2017

Yes, I mentioned that it would, but it was published as a minor version – maybe because it wasn’t intentional to begin with. Anyway, use 1.4.x (not 1.5.x) if you need to for some reason.

@brianc
Copy link
Owner

brianc commented Jul 9, 2017

My apologies for that. Out of curiosity, what did it return before?

@charmander
Copy link
Collaborator

A promise, even when a callback was provided, causing #24. Since the behaviour wasn’t documented and there was never a use case for it, though, this isn’t really a problem.

@brianc
Copy link
Owner

brianc commented Jul 9, 2017

Ohh okay cool - well this is fixed in 2.0! 💃

@brianc
Copy link
Owner

brianc commented Aug 7, 2017

My appologies for breaking backwards compat - I'll try to keep an eye out for that in the future.

@brianc brianc closed this as completed Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants