Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue line of code :) #42

Closed
DedoOne opened this issue Sep 21, 2011 · 2 comments
Closed

Rogue line of code :) #42

DedoOne opened this issue Sep 21, 2011 · 2 comments

Comments

@DedoOne
Copy link

DedoOne commented Sep 21, 2011

Hi Brian,

I could not find the purpose for the following line of code within the Jason Utility:

req.Date = date;

Left over debris? If so, perhaps table it as part of your next cleanup. :)

Roger

PS, It always nice to see the fruits of ones efforts. You can see your API at work within my Guild's website: www.aoneth.com

@ghost
Copy link

ghost commented Sep 21, 2011

I've got a bunch of changes yet to check in to my fork (once I figure out how to do it, lol), so I'll take a look at this and see if it can be removed. Thanks for the heads up!

@ghost
Copy link

ghost commented Sep 21, 2011

Not a rogue line of code. This is setting the timestamp of the currently executing HttpWebRequest. This is used in conjunction with the "If-Modified-Since" HTTP header (which is currently not implemented yet) so that if said header is included, it will only get information that has been changed since the value of the If-Modified-Since header.

So this is necessary, but good catch nonetheless. Always good to point out irregularities just in case something is caught that needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants