Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rev: accept "?" as a file #222

Merged
merged 2 commits into from
Aug 16, 2023
Merged

rev: accept "?" as a file #222

merged 2 commits into from
Aug 16, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 15, 2023

  • Argument parsing in rev treated "?" as an indication to print usage, but this is not standard behaviour
  • GNU rev and OpenBSD rev accept a file called "?" and we could accept it here
  • I tested it with: echo hello > ? && perl rev ?

@mknos
rev: accept "?" as a file
9d7bc1c 
* Argument parsing in rev treated "?" as an indication to print usage, but this is not standard behaviour
* GNU rev and OpenBSD rev accept a file called "?" and we could accept it here
* I tested it with: echo hello > \? && perl rev \?
@briandfoy briandfoy self-assigned this Aug 15, 2023
@briandfoy briandfoy added Type: bug an existing feature does not work Priority: low get to this whenever Program: rev The rev program labels Aug 15, 2023
briandfoy
briandfoy requested changes Aug 15, 2023
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more more change you need. Remove the ? test in t/rev/rev.t. It's in the last subtest. That should bet the CI checks to pass.

And, while you are there, can you rename that subtest help instead of version? It's obvious that I copied and pasted there.

@briandfoy briandfoy added the Status: changes requested adjust the pull request as noted in comments label Aug 15, 2023
@mknos
Copy link
Contributor Author

mknos commented Aug 16, 2023

Thanks for the suggestion. Unit test updated.

@briandfoy briandfoy merged commit 4f01166 into briandfoy:master Aug 16, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Type: bug an existing feature does not work Status: changes requested adjust the pull request as noted in comments Priority: low get to this whenever labels Aug 16, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix Type: bug an existing feature does not work and removed Status: accepted The fix is accepted labels Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: rev The rev program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy