Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cal: permit -j -y and -jy #259

Merged
merged 1 commit into from
Sep 23, 2023
Merged

cal: permit -j -y and -jy #259

merged 1 commit into from
Sep 23, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 23, 2023

  • Simplify options parsing
  • Previously -jy could be grouped, but not written as "-j -y" because options were expected to all be in $ARGV[0]
  • num_args does not count options
  • num_args == 0 means $month and $year are dynamically selected (month is not used if -y is set)
  • num_args == 1 means $month is not used and $year comes from args
  • num_args == 2 means $month and $year are both used and come from args (not compatible with -y)
  • Remove non-standard -? option; usage is still printed
  • Put POD after END
  • Remove POD text referring to -n option which doesn't exist

@mknos
cal: permit -j -y and -jy
fe53c48 
* Simplify options parsing 
* Previously -jy could be grouped, but not written as "-j -y" because options were expected to all be in $ARGV[0]
* num_args does not count options
* num_args == 0 means $month and $year are dynamically selected (month is not used if -y is set)
* num_args == 1 means $month is not used and $year comes from args
* num_args == 2 means $month and $year are both used and come from args (not compatible with -y)
* Remove non-standard -? option; usage is still printed
* Put POD after __END__
* Remove POD text referring to -n option which doesn't exist
@briandfoy briandfoy self-assigned this Sep 23, 2023
@briandfoy briandfoy added Type: enhancement improve a feature that already exists Program: cal The cal program Priority: low get to this whenever labels Sep 23, 2023
briandfoy
briandfoy approved these changes Sep 23, 2023
View reviewed changes
bin/cal
@@ -16,47 +16,25 @@ package
cal; # hide from PAUSE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably get rid of the special package too. Not a big deal or necessary for this.

@briandfoy briandfoy merged commit 9473faf into briandfoy:master Sep 23, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Sep 23, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cal The cal program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy