strings: better validation #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Sep 25, 2023
mknos
commented
- Option -t expects a single letter, but this version accepted stupid things like -t bedding
- $offset_format is only used if $opt_t is set; default usage does not print offset
- Directory arguments were silently failing; now print an error message for them
* The argument of option -t is a single letter * This version accepted things like -t bedding * $offset_format is only used if $opt_t is set; default usage does not print offset * Directory arguments were silently failing; now print an error message for them
briandfoy
added
Type: enhancement
briandfoy
reviewed
Sep 25, 2023
| 'o' => 1, | ||
| 'x' => 1, | ||
| ); | ||
| die($usage) unless $EXPECT{$opt_t}; |
There was a problem hiding this comment.
Let's warn and exit with the right value here
briandfoy
requested changes
Sep 25, 2023
| @@ -76,6 +81,7 @@ $chunksize = 4096; # whatever | |||
|
|
|||
| for my $filename ( @ARGV ) | |||
| { | |||
| die("'$filename' is a directory\n") if (-d $filename); | |||
briandfoy
added
the
Status: changes requested
|
I'm going to merge this and fix up those |
briandfoy
added a commit
that referenced
this pull request
Sep 25, 2023
|
I backtracked on the directories silently failing. The strings I have on FreeBSD silently ignore. If you have an example that doesn't, let me know. |
briandfoy
added
Status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.