Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xargs: standard loop termination #265

Merged
merged 1 commit into from
Sep 25, 2023
Merged

xargs: standard loop termination #265

merged 1 commit into from
Sep 25, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 25, 2023

  • Standard xargs does not terminate for all error exit codes [1], only for exit code 255 returned by the command
  • system() returns -1 if the command couldn't be started, so also treat that as a fatal error
  • With patch applied, match the behaviour of GNU xargs for the following cases
  • case1: don't terminate ls-loop if first file wasn't found

echo a b | perl xargs -n 1 ls -1
a
ls: cannot access 'b': No such file or directory

  • case2: terminate xargs for command l which doesn't exist, system() returned -1

echo a | perl xargs l
xargs: l: No such file or directory

  • case3: terminate xargs for command returning 255 (dummy example)

echo a | perl xargs perl -e'exit 255'
xargs: perl: exited with status 255

  1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/xargs.html

@mknos
xargs: standard loop termination
a6cf48d 
* Standard xargs does not terminate for all error exit codes [1], only for exit code 255 returned by the command
* system() returns -1 if the command couldn't be started, so also treat that as a fatal error
* With patch applied, match the behaviour of GNU xargs for the following cases
* case1: don't terminate ls-loop if first file wasn't found

echo a b | perl xargs -n 1 ls -1
a
ls: cannot access 'b': No such file or directory

* case2: terminate xargs for command l which doesn't exist, system() returned -1

echo a | perl xargs l
xargs: l: No such file or directory

* case3: terminate xargs for command returning 255 (dummy example)

echo a | perl xargs perl -e'exit 255'
xargs: perl: exited with status 255

1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/xargs.html
@briandfoy briandfoy self-assigned this Sep 25, 2023
@briandfoy briandfoy added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: xargs The xargs program labels Sep 25, 2023
@briandfoy briandfoy merged commit 1ee813a into briandfoy:master Sep 25, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: xargs The xargs program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy