which returns directory paths #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The following output is incorrect because the results all refer to directories $ perl which . .. / /usr/local/sbin/. /usr/local/sbin/.. /usr/local/sbin// * The command "which" is supposed to find files available to execute, not directories * Resolve this by adding explicit directory check before checking "-x $path" * Style: declare path variables to make code simpler to read
briandfoy
added
Type: bug
briandfoy
approved these changes
Sep 28, 2023
|
|
||
| if (-d $path) { | ||
| next; | ||
| } | ||
| if ($^O eq 'MacOS') { |
There was a problem hiding this comment.
Do you know why we'd single out MacOS here? I think this is Mac Classic, which we don't need to support. We don't need to change this for this PR, but it's something to think about. I wonder what happens on Windows, which has a completely different permissions model.
briandfoy
added
Status: accepted
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ perl which . .. /
/usr/local/sbin/.
/usr/local/sbin/..
/usr/local/sbin//