Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tac: continue on error #270

Merged
merged 1 commit into from
Sep 29, 2023
Merged

tac: continue on error #270

merged 1 commit into from
Sep 29, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 29, 2023

  • Previously tac would exit if one file argument could not be opened
  • Also, the filename was not reported in the error message so it was unclear which argument was at fault
  • If zero files are opened successfully, IO::Tac->new() returns undef so exit immediately
  • Now print a warning for each file that can't be opened, then continue to next argument
  • Avoid "bad read" error in by checking if argument is a directory before calling sysopen()
  • This behaviour follows cat, and GNU tac

@mknos
tac: continue on error
3b90ef2 
* Previously tac would exit if one file argument could not be opened
* Also, the filename was not reported in the error message so it was unclear which argument was at fault
* If zero files are opened successfully, IO::Tac->new() returns undef so exit immediately
* Now print a warning for each file that can't be opened, then continue to next argument
* Avoid "bad read" error in by checking if argument is a directory before calling sysopen()
* This behaviour is closer to cat, and GNU tac
@briandfoy briandfoy self-assigned this Sep 29, 2023
@briandfoy briandfoy added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tac The tac program labels Sep 29, 2023
@briandfoy briandfoy merged commit b112e71 into briandfoy:master Sep 29, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tac The tac program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy