Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sum: add md5 support #271

Merged
merged 1 commit into from
Sep 29, 2023
Merged

sum: add md5 support #271

merged 1 commit into from
Sep 29, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 29, 2023

  • ppt had no way of generating md5 sums
  • Following NetBSD sum, add an -a option for checksum algorithm
  • Keep the current meaning of -o [1-2] for old1 and old2
  • Follow NetBSD and select crc algorithm using -a crc, not -o 0
  • Move logic for selecting correct algorithm out of argument loop
  • update POD
  • md5 output tested against md5sum command on my system

@mknos
sum: add md5 support
c720ae3 
* ppt had no way of generating md5 sums
* Following NetBSD sum, add an -a option for checksum algorithm
* Keep the current meaning of -o [1-2] for old1 and old2
* Follow NetBSD and select crc algorithm using -a crc, not -o 0
* Move logic for selecting correct algorithm out of argument loop
* update POD
* md5 output tested against md5sum command on my system
@briandfoy briandfoy self-assigned this Sep 29, 2023
@briandfoy briandfoy added Type: enhancement improve a feature that already exists Program: sum The sum program Priority: low get to this whenever labels Sep 29, 2023
@briandfoy briandfoy merged commit c446f6a into briandfoy:master Sep 29, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: sum The sum program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy