Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

look: reject multiple file arguments #274

Merged
merged 1 commit into from
Sep 30, 2023
Merged

look: reject multiple file arguments #274

merged 1 commit into from
Sep 30, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 30, 2023 •
edited

  • Delete some code by switching to getopts()
  • Bad usage case 1: look requires a pattern argument to search for, but this version allowed no pattern

$ perl look | wc -l
101924

  • Bad usage case 2: look requires zero or one file argument, but this version didn't raise error for multiple files
  • Update usage string and SYNOPSIS
  • Skip directories in FILE loop

@mknos
look: reject multiple file arguments
7906099 
* Delete some code by switching to getopts()
* Bad usage case 1: look requires a pattern argument to search for, but this version allowed no pattern
$ perl look | wc -l
101924

* Bad usage case 2: look requires zero or one file argument, but this version didn't raise error for multiple files
* Update usage string and SYNOPSIS
* Skip directories in FILE loop
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: look The look program labels Sep 30, 2023
@briandfoy briandfoy self-assigned this Sep 30, 2023
@briandfoy briandfoy merged commit ac556f7 into briandfoy:master Sep 30, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: look The look program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy