Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what: do not read stdin #456

Merged
merged 1 commit into from Feb 12, 2024
Merged

what: do not read stdin #456

merged 1 commit into from Feb 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 12, 2024

  • The pod manual doesn't mention reading from standard input
  • The version on my OpenBSD system prints usage if no arguments are given
  • Standards document describes file argument as being required (no implicit stdin) [1]
  • Standards document explicitly says standard input is not used, i.e. no special argument or option to signify stdin
  • When testing this I discovered invalid option -x did not raise an error, so add error handling
  • Below output is from my linux system: two of the file arguments have patterns to display
  1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/what.html
%perl what /bin/gprof /bin/bash /bin/echo
/bin/gprof:
         Copyright (c) 1983 Regents of the University of California.
/bin/bash:
        Bash version 5.1.4(1) release GNU
/bin/echo:

@mknos
what: do not read stdin
406cadf 
* The pod manual doesn't mention reading from standard input
* The version on my OpenBSD system prints usage if no arguments are given
* Standards document describes file argument as being required (no implicit stdin) [1]
* Standards document explicitly says standard input is not used, i.e. no special argument or option to signify stdin
* When testing this I discovered invalid option -x did not raise an error, so add error handling
* Below output is from my linux system: two of the file arguments have patterns to display

1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/what.html

%perl what /bin/gprof /bin/bash /bin/echo
/bin/gprof:
         Copyright (c) 1983 Regents of the University of California.
/bin/bash:
        Bash version 5.1.4(1) release GNU
/bin/echo:
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: what The what program labels Feb 12, 2024
@briandfoy briandfoy merged commit 9aad27c into briandfoy:master Feb 12, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Feb 12, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 12, 2024
@briandfoy
Copy link
Owner

changes: invalid options die; no longer supports stdin

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: what The what program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy