Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

look: standard exit code #473

Merged
merged 1 commit into from Feb 29, 2024
Merged

look: standard exit code #473

merged 1 commit into from Feb 29, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 27, 2024

  • Exit code 0 means one or more lines were found based on input search pattern
  • Exit code 1 means no lines were found
  • Exit code 2 means the program failed (e.g. bad path for argument2)
  • Clarify this by declaring 3 constants
  • With this patch, usage() exits correctly with 2
  • Style: remove global $def_dict, which is a function of global $filearg

@mknos
look: standard exit code
0d98817 
* Exit code 0 means one or more lines were found based on input search pattern
* Exit code 1 means no lines were found
* Exit code 2 means the program failed (e.g. bad path for argument2)
* Clarify this by declaring 3 constants
* With this patch, usage() exits correctly with 2
* Style: remove global $def_dict, which is a function of global $filearg
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: look The look program labels Feb 27, 2024
@briandfoy briandfoy merged commit 46077ed into briandfoy:master Feb 29, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 29, 2024
@briandfoy briandfoy self-assigned this Feb 29, 2024
@briandfoy
Copy link
Owner

changes: standardize exit codes

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: look The look program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknos @briandfoy