Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owp$overplot depends on owp$params which depends on owp$summary #43

Open
briandk opened this issue Jul 10, 2011 · 0 comments
Open

owp$overplot depends on owp$params which depends on owp$summary #43

briandk opened this issue Jul 10, 2011 · 0 comments
Labels

Comments

@briandk
Copy link
Owner

briandk commented Jul 10, 2011

Since, ideally, owp$overplot is just augmented summary information, we end up storing summary information PLUS one column of overplotting information in a separate part of owp:

 owp                       <- AdaptVariablesFromGranovaComputations()
 owp$summary               <- GetSummary(owp)
 owp$group.mean.line       <- GetGroupMeanLine(owp)
 owp$params                <- GetGraphicalParameters(owp)
 owp$overplot              <- AddOverplotInformation(owp$summary, "contrast", 2*owp$params$horizontal.percent)

We should think about how to reduce this dependency chain. But, right now params depend on summary, and overplot depends on both.

(As of 1dc5893)

@briandk briandk closed this as completed Aug 24, 2011
@briandk briandk reopened this Aug 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant