Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error instead of using log.Fatalln #2

Closed
tejainece opened this issue Dec 7, 2014 · 2 comments
Closed

Return error instead of using log.Fatalln #2

tejainece opened this issue Dec 7, 2014 · 2 comments
Labels
bug

Comments

@tejainece
Copy link

Error should be returned in the case of calls like DailyByName, etc. Exiting because something cannot be parsed is not the right behavior.
@briandowns
Copy link
Owner

I see what you mean. The forecast code is kind of a mess. I can probably get to this sometime today unless you had a PR planned and I'll gladly wait.

@briandowns briandowns added the bug label Dec 7, 2014
@briandowns briandowns mentioned this issue Dec 8, 2014
Merged
@briandowns
Copy link
Owner

This has been fixed in #3 .

@briandowns briandowns mentioned this issue Dec 8, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tejainece @briandowns