Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning is not correct for go mod #83

Closed
billykwooten opened this issue May 15, 2020 · 3 comments
Closed

versioning is not correct for go mod #83

billykwooten opened this issue May 15, 2020 · 3 comments

Comments

@billykwooten
Copy link
Contributor

billykwooten commented May 15, 2020

Hello! So as of go 1.13 go mod requires semantic versioning for all it's modules including the v in front of the version.

I noticed that the versions released with this are v.0.15.0 for example, with an extra period in-between the v and the semantic version. This breaks go mod completely when trying to pull the required version.

@briandowns
Copy link
Owner

Thanks for reporting this. I hadn't noticed. This is entirely a mistake on my part. I'll look to see how much activity those tags are getting and if it's minimal, I'll retag them. In the meantime, here's a new tag with your latest changes include. https://github.com/briandowns/openweathermap/releases/tag/v0.16.0

@billykwooten
Copy link
Contributor Author

billykwooten commented May 15, 2020

No problem, since i'm around this module right now figured i'd bring this up too! Thanks for fixing it! Modules are working with that new tag now.

@briandowns
Copy link
Owner

Awesome. Thanks for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants