Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change How Binary Cache Works #19

Closed
briandowns opened this issue Dec 31, 2017 · 1 comment
Closed

Change How Binary Cache Works #19

briandowns opened this issue Dec 31, 2017 · 1 comment

Comments

@briandowns
Copy link
Owner

The current implementation uses the URL in the request as the cache key. This prevents calls to the functions in the same repo from being executed since the binary cache will only contain a binary for the vert first function called.

There are a number of ways to resolve this.

  • Append the function name to the repo and use that as the cache key
  • Create a hash of the 2 strings and use the case
  • ?
@briandowns
Copy link
Owner Author

Resolved via #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant