Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration test to create a new task #75

Merged
merged 14 commits into from Oct 29, 2018
Merged

Added integration test to create a new task #75

merged 14 commits into from Oct 29, 2018

Conversation

mmcc007
Copy link
Collaborator

@mmcc007 mmcc007 commented Oct 2, 2018

Modified new task screen for redux project. The new task screen for other projects probably need to be modified.

Runs the integrations test on ios in travis

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #75 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   62.19%   62.08%   -0.12%     
==========================================
  Files         124      124              
  Lines        2812     2817       +5     
==========================================
  Hits         1749     1749              
- Misses       1063     1068       +5
Impacted Files Coverage Δ
...ample/mvi_flutter/lib/screens/add_edit_screen.dart 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7fbab...d4ba5fc. Read the comment docs.

Updated add/modify screen for all projects except MVU to work with driver
Added timeouts for some driver commands in integration tests for CI
Fixed all builds for ios and android
Running integration tests on android in CI
@brianegan
Copy link
Owner

brianegan commented Oct 5, 2018

Oh wow -- I wasn't able to get the integration tests running on Travis last time I tried -- I ran into Out of Memory errors. Did this setup work!? If so, massive kudos :)

Ah, looks like it ran but hit some errors. Not sure why it shows a green build :/ Looks like the problem was that the test took too long to complete. I wonder if we'll need to split each app run out into it's own travis job.

@mmcc007
Copy link
Collaborator Author

mmcc007 commented Oct 6, 2018

I guess they increased default memory for their images since then 👍

Yea, the android job is running into max time limit for jobs (50 mins) and ios job is close to hitting that limit. Travis reports green since the jobs are failable. Splitting into separate (non-failable) jobs per project might be the simplest way to go for now.

Occasionally jobs will fail randomly (transient flutter driver errors, network timeouts, android emulator issues....) so keeping them separate allows resubmitting each failing job until travis reports a successful overall build. Travis has an auto retry option to help minimize.

Looks like it is allowing 5 jobs to run at a time. Takes over an hour to finish! 😲
Allows resubmitting failed jobs after build fails (for a passing build)

Fixed some failing integration tests
.travis.yml and removed dependency on travis for android
Added fastlane to vanilla app as placeholder for implementing deploy 🤓
@mmcc007
Copy link
Collaborator Author

mmcc007 commented Oct 11, 2018

The one failing job should pass if u resubmit the job. Here is the same code with all the jobs passing:
https://travis-ci.org/mmcc007/flutter_architecture_samples/builds/439978568.

codecov.io was down during the build (what are the odds!) so it may have missed the report. Could try resubmitting the unit test job to see if the result appears here.

All the red x's next to the commits, other than for bad builds, are due to the reduction in code coverage of 0.12%!

Other than that it looks good to me!

@brianegan
Copy link
Owner

Great, thanks again for such a good contribution :) I'm so happy we can run these tests on CI now!

Once the tests go green, I'll merge it up (might be tomorrow morning if they take a bit).

@mmcc007
Copy link
Collaborator Author

mmcc007 commented Oct 11, 2018

No prob, it was a great learning experience. Maybe some day we can demo deploying one of the apps to both of the stores with a tagged release or something. That would be cool.

The build succeed this time, so should be good to go 👍

@mmcc007
Copy link
Collaborator Author

mmcc007 commented Oct 29, 2018

Hey... I have a PR I can start for #79. If this one is good to go I can start the other one

@brianegan brianegan merged commit 4bf4970 into brianegan:master Oct 29, 2018
@brianegan
Copy link
Owner

brianegan commented Oct 29, 2018

Thanks @mmcc007! That was my bad -- I read the CodeCov report as a failure rather than a very small reduction in coverage.

I've merged this up! Please feel free to submit a PR for #79 :)

Again -- amazing contributions. I've gone ahead and added you as a collaborator to this project, so if you see things like this go green in the Future you should be able to merge it up!

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants