-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error after updating to 0.4.0 #28
Comments
@driveddy Hrm, that's pretty weird... The problem appears to be: Your app is looking up the Widget tree for the StoreProvider and can't find anything. I'm not sure why that would be broken taking a look at your example. We have tests for that exact case... Could you please try pulling this repo down locally and running the example to see if it works for ya? Thanks! |
sure will do |
Ok now it works. Still don't know what went wrong... But I found another issue related to https://github.com/brianegan/redux_logging
Im trying to figure out whats wrong with it. This didn't happened before |
@driveddy Haha, beta language with a beta framework, might be something just a bit weird going on! I've run into quite a few odd issues with Dart 2 thus far :) 👻 👻 👻 Thanks for the report wrt redux_logging. I've created an issue on that repo as a reminder to take a look soon. |
I had the same problem, had to drop back to < 0.4.0 on my main project. I did clone flutter_redux and attempt to build the example, but it fails, actually a compiler error where it doesn't like the line
When I try to run the example, ignoring the error, it throws `[✓] Flutter (Channel beta, v0.1.5, on Mac OS X 10.13.3 17D102, locale en-US) [✓] Android toolchain - develop for Android devices (Android SDK 27.0.3) [✓] iOS toolchain - develop for iOS devices (Xcode 9.2) [✓] Android Studio (version 3.0) [✓] VS Code (version 1.21.1) [!] Connected devices ! Doctor found issues in 1 category.` |
@jack4git Ah dang, sorry about that, and thanks for the report! Could you please try running the example with the latest version? I forgot to add @driveddy Any idea how you got it to work that might help us resolve this for others? Hard to say if it might just be a Dart 2 bug or if we've got a bug somewhere. |
|
@jack4git Thanks for the stack trace! Hrm, this is truly odd... I'm able to run the example on both Android and iOS using the beta branch and the Let me push up a branch to see if I can get it working! |
@jack4git If you get some time, could you please do me a favor and pull down the |
The generics-methods-check branch built / ran, no errors. |
@jack4git Ok, thanks for the letting me know! Could you please try using the |
Happy to do so. My main flutter installation is Channel beta, v0.1.5 ... how would I go about building this example on flutter master while leaving other things alone? |
@jack4git Excellent, certainly appreciate it! To test different versions, I actually installed flutter twice on my system. Once in a directory called "flutter" and again in "flutter-dev." I normally use the beta branch in the "flutter" directory and set that as my path, but if I need to try something out quickly, I'll change my path over to use "flutter-dev" which tracks the dev or master branch. |
I used flutter channel command this time -- everything is good when building flutter-redux master on flutter master. As far as switching paths goes, do you mean both PATH= and FLUTTER_ROOT =? |
@jack4git Yep, exactly! You can also change channels the way you described, but I was having some funny issues with that every once in a while :) Overall, great to hear the issue is fixed on master flutter / master flutter_redux. This confirms my suspicion that the problem has to do with how Dart 2 handles generic type parameters for functions. Generic type parameters should be fully supported, but it sounds like the Dart2 SDK that ships with the beta channel might not be quite working. I'll leave the library as-is for now, rather than introducing another breaking change, and hopefully with the next beta push these issues with the Dart 2 SDK will be resolved. Again, thank you so much for taking the time to hunt this down with me! |
Brian, with the new Flutter beta version, I figured I'd try flutter_redux 4 again (now 4.1).
Doctor: [!] Android toolchain - develop for Android devices (Android SDK 27.0.3) [✓] iOS toolchain - develop for iOS devices (Xcode 9.2) [✓] Android Studio (version 3.0) [✓] VS Code (version 1.21.1) [✓] Connected devices (1 available) Might not be flutter_redux of course but wondering if this error is familiar ... |
Thanks for the report @jack4git! Sorry about the problems :( Hrm, that's a curious one. Looks like there's something going wrong with the VM in some way... Another possibility: are you using Hoping to get that pushed up tonight, and released in the next day or two! After that, if all works out, it might be worth trying again to see if that fixes your error or not. I'll update this thread when it's released. |
@brianegan I was having this problem on $ flutter --version
Flutter 0.2.3 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 5a58b36e36 (2 weeks ago) • 2018-03-13 13:20:13 -0700
Engine • revision e61bb9ac3a
Tools • Dart 2.0.0-dev.35.flutter-290c576264 Works here however: Flutter 0.2.5-pre.75 • channel master • https://github.com/flutter/flutter.git
Framework • revision 35a7f43749 (7 minutes ago) • 2018-03-29 15:37:05 -0400
Engine • revision 6473f1b106
Tools • Dart 2.0.0-dev.41.0.flutter-2f68e82526 Happy Easter! |
Heya @rhodee -- thanks so much for the test case! And very sorry about the problem. I'll take a look and see what's happening. Happy Easter to you as well :) |
Hey @rhodee, once again -- thanks for taking the time to make that test case. The bad news: It totally works on my machine using the Flutter I really think there's an underlying Dart 2 bug around reified generic functions that hasn't landed on Beta, but seems to have landed on master. According to the Dart team a couple days ago: "--preview-dart-2 is intended to subsume --reify-generic-functions at some point, but it might not have happened yet. It's a matter of days and exact version numbers..." Let's hope the next version of Beta will include a more stable Dart 2 including the new reified generic functions (which this library depends on)! |
Hey all -- I've published a new version: 0.5.0. It now works with Redux 3.0.0 (just published), which fixes the issues with Dart 2 + combining Reducers. Please see the migration guide for Redux to update your projects. Unfortunately for some, the "No Store" problem might exist until Dart 2 is fully stable with reified generic types, which this library depends on. While beta channel works fine for me, it seems to be broken for others. Using the master channel may solve the problem. |
Brian, one new data point: I am able to successfully build and run your flutter_redux example using flutter_redux 0.5.0 with redux 3.0.0 on the most recent flutter beta channel. (Dart 2 Preview) |
Brian, another data point: my app is now running fine using Dart 2 preview: flutter_redux 0.5.0, redux 3.0.0, redux_logging 0.3.0, flutter_blue 0.3.3. Not sure what in this mix was causing troubles previously, most likely a combination of things ;-) |
Excellent, glad to hear it's working again! Yep, those are the latest versions of each package and should all hopefully work for Dart 2 :) Please do let me know if ya run into any trouble! |
Hey all, I'm gonna go ahead and close this issue for now. The 0.5.0 version seems to be working for most folks on the beta or Master branches. Thanks for all the reports, and please let me know if you run into this any further! |
Hey @brianegan
after updating to
0.4.0
Im getting the following error. Any idea what could cause the issue?flutter Doctor
Main
App
The text was updated successfully, but these errors were encountered: