Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to navigate in a CupertinoApp #79

Closed
enyo opened this issue Sep 21, 2018 · 3 comments
Closed

How to navigate in a CupertinoApp #79

enyo opened this issue Sep 21, 2018 · 3 comments

Comments

@enyo
Copy link

enyo commented Sep 21, 2018

With a MaterialApp you can provide the navigatorKey and use that in your middleware to redirect the user if necessary.

But CupertinoApp doesn’t have a navigatorKey.

Now what we are doing is to add the context to the action so we have access to it in the middleware, but this seems very wrong.

Do you have a proposal on how to do this best?

@brianegan
Copy link
Owner

brianegan commented Sep 28, 2018

Hrm, that's a problem indeed.

Lemme see if I can follow up with the Flutter team on why they don't provide a navigatorKey in the same way... Feels like a problem more folks are going to run into!

@brianegan
Copy link
Owner

And looks like ya beat me to it :) flutter/flutter#22258

I'll close this one out, since I don't think this library should offer a workaround to the underlying problem, and now the underlying problem is solved :)

Thanks for the report!

@enyo
Copy link
Author

enyo commented Sep 28, 2018

Indeed @brianegan . Sorry, I completely forgot to close this issue! Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants