Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks vim plugins #4

Open
dwlsalmeida opened this issue Dec 27, 2018 · 6 comments
Open

Breaks vim plugins #4

dwlsalmeida opened this issue Dec 27, 2018 · 6 comments

Comments

@dwlsalmeida
Copy link

Specifically this https://marketplace.visualstudio.com/items?itemName=vscodevim.vim

but a few others too..

@briankendall
Copy link
Owner

Unfortunately there's no way for this plugin not to break this vim plugins since it uses the same technique of overriding Code's type command. As far as I understand, only one extension can do that at a time. Until Code introduces a more direct API for modifying formatting behavior on the fly I'm afraid there's nothing I can do to fix this.

@dwlsalmeida
Copy link
Author

@briankendall Then I suggest a shortcut to toggle this extension. It does not need to be on all the time.

@dwlsalmeida
Copy link
Author

I suppose nothing has changed regarding this? :/
If this could work on the modified lines whenever the file is saved I believe this issue would be solved. I would help if I could but I know nothing about javascript let alone vscode extension programming...

@briankendall
Copy link
Owner

Admittedly I haven't touched this in a while, especially since it's been working for me (as I do not use vim plugins).

I haven't checked back to see whether Code has added the necessary APIs to allow this without overriding type. If it has then I could update the extension.

@j-proc
Copy link

j-proc commented Feb 27, 2021

Just an FYI microsoft/vscode#13441

There's been a lot of issues. The latest discussion does seem to imply an ability to make a temporary claim.

@briankendall
Copy link
Owner

I've been waiting for VSCode to implement a proper API for hooking into typing since I first wrote this extension. (And apparently others have been waiting even longer than that!) It seems that it still does not have the API required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants