Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QOL] Csv column cleaning, remove 'ETH' & 'Txn count' #36

Open
brianleect opened this issue Jun 16, 2023 · 1 comment
Open

[QOL] Csv column cleaning, remove 'ETH' & 'Txn count' #36

brianleect opened this issue Jun 16, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brianleect
Copy link
Owner

Problem

  • Column not used.
  • By removing it we will have more clarity on actual changes to our labels when scraped, rather than seeing changes due to ETH change or txn count changes.

Action

  • Remove all 'ETH' & 'Txn count' from existing csv
  • Modify main.py to drop the relevant columns before saving
@brianleect brianleect added enhancement New feature or request good first issue Good for newcomers labels Jun 16, 2023
@brianleect
Copy link
Owner Author

Do we consider 'Market Cap' and 'Holders' information we want to leave in the csv? Seems useful somewhat but same problems with regards to clarity, we will unlikely notice changes in label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brianleect