Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with pycryptodome #32

Open
davedoesdev opened this issue Jul 12, 2017 · 0 comments
Open

Doesn't work with pycryptodome #32

davedoesdev opened this issue Jul 12, 2017 · 0 comments

Comments

@davedoesdev
Copy link
Contributor

davedoesdev commented Jul 12, 2017 •
edited
Loading

pycrypto is dead. pycryptodome is a drop-in replacement.
However, python-jws uses a private member (_RSAobj) of pycrypto:

https://github.com/brianloveswords/python-jws/blob/master/jws/algos.py#L87

which pycryptodome doesn't have.

But pycryptodome does have the RsaKey member in the same place.

So a change something like https://github.com/mpdavis/python-jose/pull/8/files#diff-f5aa2743c17dabc292333673fe591c30R20 is required where the presence of each member is checked for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davedoesdev