-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add Slot Resolutions in the IntentRequest #20
Comments
Hi, see #17 |
Ah I didn't spot that issue somehow. Need better glasses. Thank you for the quick reply 👍 |
@eemmzz can you please test and review the feature I added to the master branch? This should provide the requested functionality. |
@hoegertn thank you, I'll give it a go tomorrow |
We had a look at the changes, and this has helped us for some initial testing but we had some extra feedback:
|
Thanks for the feedback:
|
Allowing us to set it as null would be fine. And ah ok regarding setting the object directly on the request. Would it be worth updating the examples to include slot resolutions? Also any idea when this will be published to npm? |
Updating the examples sound good. Would you mind creating a PR for this? I'm currently on holiday with poor wifi. Will release to npm when I am back on Wednesday. |
Created the following PR #22 |
added the ER_SUCCESS_NO_MATCH case and the possibility to add multiple resolutions. Published as version 1.1.1 |
I'd like to be able to test synonym resolution logic in my Alexa skill but currently this framework doesn't allow any extension of the basic
{name: "SlotName", value: "SlotValue"}
structure.I need to be able to add a resolutions object to a slot as documented here: https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/entity-resolution-for-slot-types#intentrequest-changes
See below example JSON from the above link.
Currently
getIntentRequest
does the following logic for slots:I would propose that instead we're allowed to inject the slots object as required. The Alexa SDKs will be changing quite frequently due to the constant shift in this new technology and frameworks like these will need to be able to keep up. So I would propose the following change:
And remove the if/else logic referenced above.
This allows users of the test framework to pass through whatever slot configurations they need. A user may pass through an invalid object but if they do their tests will fail and alert them to that.
I'm more than happy to raise a PR for this if the idea is accepted. We would really like to keep using this test framework.
The text was updated successfully, but these errors were encountered: